-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce instance mappings #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need tests to ensure all the new index-level endpoints work:
Index.get_loaded_models(), etc.
Feel free to copy/paste/modify the existing tests to make this faster
@pandu-k Those are already implemented as tests and were tested they work correctly both on V2 on local setup |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Introduces new class MarqoInstanceMappings that allows user to specify url for each index to use for index-specific api requests. Moves certain methods from Client class to Index class and deprecates those used in Client
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: