remove server batch #113
Merged
remove server batch #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pandu-k
approved these changes
Jul 5, 2023
danyilq
pushed a commit
that referenced
this pull request
Jul 9, 2023
danyilq
added a commit
that referenced
this pull request
Jul 11, 2023
* MC-35 marqo GA changes * remove server batch (#113) * MC-35 add tests and changes after review * resolve url only when needed for index + improve tests * improves for edgecases * use correct expiration time * add error handling for indices * timeout for slow refresh + tests ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
remove the
server_batch_sizein add_documents APIWhat is the current behavior? (You can also link to an open issue here)
we have an argument
server_batch_sizeWhat is the new behavior (if this is a feature change)?
The argument
server_batch_sizeis removedDoes this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes
Other information:
The related marqo pr is Remove server batch, add_documents_orchestrator, and revise device logic marqo#527
pytest is passed
