Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNK fails to identify an improper number #8

Closed
j-pk opened this issue Nov 6, 2015 · 3 comments
Closed

PNK fails to identify an improper number #8

j-pk opened this issue Nov 6, 2015 · 3 comments

Comments

@j-pk
Copy link

j-pk commented Nov 6, 2015

I made a simple textfield to test various phone number inputs.

This # entry 202 00e 0000 returns with a PremiumRate type and the toE164 string value is +1202003000

It does appear to be taking the alphabetical keypad entry you find on a phone and converting its value. So, would this be a valid entry or should an error return stating it's not a number?

Anyways, just thought I share my findings.

@marmelroy
Copy link
Owner

Ah yes... good find. Looks like I didn't throw an error at the right place. Fix very soon.

marmelroy added a commit that referenced this issue Nov 6, 2015
@marmelroy
Copy link
Owner

Fixed with 0.1.6. Thanks again @j-pk

@marmelroy
Copy link
Owner

Also added an automatic test to make sure this issue doesn't come back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants