Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useUpdate throws an error when record id is a valid falsy value such as zero #9957

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fix useUpdate throws an error when record id is a valid falsy value such as zero #9957

merged 1 commit into from
Jun 26, 2024

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jun 26, 2024

Problem

useUpdate throws an error when record id is a valid falsy value such as zero

Introduced in #9741

Solution

Fix the condition to check only for null or undefined

@djhi djhi added the RFR Ready For Review label Jun 26, 2024
@fzaninotto fzaninotto merged commit b2c6b17 into master Jun 26, 2024
14 checks passed
@fzaninotto fzaninotto deleted the fix-use-update-id-falsy-values branch June 26, 2024 13:40
@fzaninotto fzaninotto added this to the 5.0.2 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
5.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@djhi @fzaninotto