[Doc] Explain how to change page with useNavigation
#9840
Conversation
| @@ -1,5 +1,6 @@ | |||
| import { useCallback } from 'react'; | |||
| import { useNavigate, To } from 'react-router-dom'; | |||
| import { Location } from 'history'; | |||
There was a problem hiding this comment.
Why don't you import the To type imported from 'react-router-dom' above? It would avoid the added dependency
There was a problem hiding this comment.
Because there is any state key in a To object. And in our first discussion on it your speak about this state
| <ul> | ||
| <li> | ||
| <button onClick={() => redirect('/dashboard')}> | ||
| Dashboard |
There was a problem hiding this comment.
I'd use types as labels for your buttons: Relative url, View name, View name with details, Location, Function
There was a problem hiding this comment.
Nice idea, applied 👍
|
Now, I'm thinking: since we offer exactly the same API as usenavigate, why would isers choose to use useredirect ? we should better document usenavigate rather than modify our API to mimic it |
docs/useRedirect.md
Outdated
| @@ -46,3 +46,28 @@ redirect(false); | |||
| ``` | |||
|
|
|||
| Note that `useRedirect` allows redirection to an absolute URL outside the current React app. | |||
|
|
|||
| ## `useNavigate` | |||
There was a problem hiding this comment.
polish: I'd put this section in a tip but it's a personal opinion.
Co-authored-by: adrien guernier <adrien@marmelab.com>
…ct-admin into feat/useRedirect/to
fzaninotto
changed the title
To from react-router in useRedirectuseNavigation
Problem
Sometimes, you’d like to pass a state when redirecting. However the
redirectonly accept a string.Solution
Change theredirectandRedirectToFunctionfunctions signature to accept aLocationfromreact-routerDocument useNavigate
Todo
- [x] Accept the right props- [x] Add a storyituseNavigate more