Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Document <EditInDialogButton> deletion side effect #9425

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Nov 7, 2023

  • Add "Redirection After Deletion" section
  • Detail missing props

docs/EditInDialogButton.md Outdated Show resolved Hide resolved
docs/EditInDialogButton.md Outdated Show resolved Hide resolved
docs/EditInDialogButton.md Outdated Show resolved Hide resolved
docs/EditInDialogButton.md Outdated Show resolved Hide resolved
docs/EditInDialogButton.md Outdated Show resolved Hide resolved
docs/EditInDialogButton.md Outdated Show resolved Hide resolved
@slax57 slax57 requested a review from adguernier November 7, 2023 15:41
| Prop | Required | Type | Default | Description |
| -------------- | -------- | ----------------- | ------- | ----------- |
| `children` | Required | `ReactNode` | | The content of the dialog. |
| `ButtonProps` | Optional | `object` | | Object containing props to pass to Material UI's `<Button>`. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `ButtonProps` | Optional | `object` | | Object containing props to pass to Material UI's `<Button>`. |
| `ButtonProps` | Optional | `object` | | Object containing props to pass to Material UI's [`<Button>`](https://mui.com/material-ui/react-button/). |

@adguernier adguernier modified the milestone: 4.15.4 Nov 7, 2023
@adguernier adguernier merged commit 6c83335 into master Nov 7, 2023
@adguernier adguernier deleted the doc-editindialogbutton-redirection branch November 7, 2023 16:41
@adguernier adguernier added this to the 4.15.4 milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants