Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for confirmColor prop to <DeleteButton> and <BulkDeleteButton> #9342

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

IAmVisco
Copy link
Contributor

@IAmVisco IAmVisco commented Oct 7, 2023

Closes #9322

@IAmVisco IAmVisco changed the title Pass confirmColor from DeleteButton to Confirm [RFR] Pass confirmColor from DeleteButton to Confirm Oct 7, 2023
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, one more thing actually, could you please also document this prop in Buttons.md?
Thanks

@IAmVisco
Copy link
Contributor Author

IAmVisco commented Oct 9, 2023

Shoot, completely forgot about that one. Will do!

Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slax57 slax57 added this to the 4.15.0 milestone Oct 9, 2023
@slax57 slax57 merged commit f348143 into marmelab:next Oct 9, 2023
8 checks passed
@slax57 slax57 changed the title [RFR] Pass confirmColor from DeleteButton to Confirm Add support for confirmColor prop to <DeleteButton> and <BulkDeleteButton> Oct 9, 2023
@IAmVisco IAmVisco deleted the delete-button-confirm-color branch October 9, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants