Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useStore internal state reset when key changes #8058

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Fix useStore internal state reset when key changes #8058

merged 2 commits into from
Aug 10, 2022

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Aug 9, 2022 •
edited
Loading

Fix useStore hook not resetting its internal state when the key changes.

Issue identified while working on #8042

  • Fix useStore hook
  • Unit test
  • Fix E2E tests

@slax57 slax57 added the RFR Ready For Review label Aug 9, 2022
@antoinefricker
Copy link
Contributor

Fixes #8022

@slax57 slax57 added WIP Work In Progress and removed RFR Ready For Review labels Aug 10, 2022
@slax57 slax57 added RFR Ready For Review and removed WIP Work In Progress labels Aug 10, 2022
@fzaninotto fzaninotto merged commit 6fc2039 into master Aug 10, 2022
@fzaninotto fzaninotto deleted the fix-useStore-internal-state-reset branch August 10, 2022 10:03
@fzaninotto fzaninotto added this to the 4.2.7 milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@slax57 @antoinefricker @fzaninotto