Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AutocompleteInput optionText returning an element throws error #7289

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Fix AutocompleteInput optionText returning an element throws error #7289

merged 2 commits into from
Feb 23, 2022

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Feb 22, 2022 •
edited
Loading

Fixes #7286

  • Added test if optionText was a function and there where no inputText prop.
  • Fix useChoices could treat an element as a string

@WiXSL WiXSL modified the milestones: 2.9.10, 3.19.11 Feb 22, 2022
@vercel vercel bot temporarily deployed to Preview – react-admin February 22, 2022 14:59 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin-storybook February 22, 2022 14:59 Inactive
@WiXSL WiXSL added the RFR Ready For Review label Feb 22, 2022
@WiXSL WiXSL mentioned this pull request Feb 23, 2022
Merged
@fzaninotto fzaninotto merged commit c7da672 into master Feb 23, 2022
@fzaninotto fzaninotto deleted the fix-autocompleteinput branch February 23, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.19.11
Development

Successfully merging this pull request may close these issues.

AutocompleteInput: TypeError: can't access property "record", getChoiceText(...).props is undefined
2 participants
@WiXSL @fzaninotto