Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Add Notification multiLine prop #6191

Closed
wants to merge 58 commits into from
Closed

[RFR] Add Notification multiLine prop #6191

wants to merge 58 commits into from

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Apr 19, 2021 •
edited
Loading

This change enables Notification component to show multi-line messages.

@fzaninotto
Copy link
Member

Can you please document usage, unit test it, and attach a screenshot about the rendered notification?

@WiXSL
Copy link
Contributor Author

WiXSL commented Apr 19, 2021

Absolutely

@WiXSL WiXSL force-pushed the add-notification-multiline branch from 0be4bb4 to 4f35650 Compare May 11, 2021 02:12
@WiXSL
Copy link
Contributor Author

WiXSL commented May 11, 2021

notification

@WiXSL WiXSL force-pushed the add-notification-multiline branch from f13f132 to 63d1e68 Compare June 1, 2021 14:34
@fzaninotto fzaninotto closed this Jul 8, 2021
@fzaninotto fzaninotto deleted the branch marmelab:master July 8, 2021 16:04
@fzaninotto
Copy link
Member

This PR was automatically closed by GitHub, I'm reopening it. Sorry for the noise.

@fzaninotto fzaninotto reopened this Jul 8, 2021
@fzaninotto fzaninotto deleted the branch marmelab:master September 7, 2021 09:55
@fzaninotto fzaninotto closed this Sep 7, 2021
@WiXSL
Copy link
Contributor Author

WiXSL commented Sep 7, 2021

This was closed, but valid

@fzaninotto
Copy link
Member

Right, sorry. Reopening.

@fzaninotto fzaninotto reopened this Sep 8, 2021
@WiXSL WiXSL force-pushed the add-notification-multiline branch from 63d1e68 to f094d74 Compare September 10, 2021 20:12
@fzaninotto
Copy link
Member

I see that you've updated this PR, but you didn't take my review into account. Could you please introduce the new signature together with the multiline option?

@WiXSL
Copy link
Contributor Author

WiXSL commented Sep 11, 2021 •
edited
Loading

I'm getting errors from failing tests related to code that is in master but not ported to next branch

@WiXSL WiXSL requested a review from fzaninotto September 11, 2021 21:52
@WiXSL WiXSL mentioned this pull request Sep 11, 2021
Closed
@WiXSL WiXSL force-pushed the add-notification-multiline branch from e94823d to f4faee0 Compare September 14, 2021 20:14
@WiXSL
Copy link
Contributor Author

WiXSL commented Sep 14, 2021

I'm getting errors from failing tests related to code that is in master but not ported to next branch

Now is ok

@WiXSL WiXSL changed the title Add Notification multiLine prop [RFR] Add Notification multiLine prop Sep 14, 2021
@djhi djhi deleted the branch marmelab:master October 4, 2021 09:03
@djhi djhi closed this Oct 4, 2021
@djhi djhi reopened this Oct 4, 2021
Travis CI and others added 19 commits October 11, 2021 16:43
@WiXSL WiXSL force-pushed the add-notification-multiline branch from f4faee0 to a532981 Compare October 12, 2021 19:31
@djhi
Copy link
Collaborator

djhi commented Oct 13, 2021 •
edited
Loading

Sorry @WiXSL, this can now target the master branch as it will be released as 3.19. Unless you'd like to wait for 4.0.0

@WiXSL
Copy link
Contributor Author

WiXSL commented Oct 13, 2021

Sorry @WiXSL, this can now target the master branch as it will be released as 3.19. Unless you'd like to wait for 4.0.0

Ok, not a problem, I'll change it

@WiXSL WiXSL changed the base branch from next to master October 13, 2021 14:48
This was referenced Oct 13, 2021
Merged
Merged
@WiXSL WiXSL closed this Oct 13, 2021
@WiXSL WiXSL deleted the add-notification-multiline branch October 14, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto Awaiting requested review from fzaninotto

Assignees
No one assigned
Labels
needs more info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WiXSL @fzaninotto @djhi