Fix validation documentation & Submission Errors Cannot Have Translatable Error Objects #6140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fzaninotto Should I target the |
WiXSL
reviewed
Apr 9, 2021
docs/CreateEdit.md
Outdated
| @@ -1281,10 +1286,11 @@ export const UserCreate = (props) => ( | |||
| <TextInput label="Email" source="email" validate={validateEmail} /> | |||
| <TextInput label="Age" source="age" validate={validateAge}/> | |||
| <TextInput label="Zip Code" source="zip" validate={validateZipCode}/> | |||
| <SelectInput label="Sex" source="sex" choices={[ | |||
| <SelectInput label="Genre" source="genre" choices={[ | |||
There was a problem hiding this comment.
You don't even wait for merged docs anymore 😂 Thanks!
There was a problem hiding this comment.
Tried to be more inclusive and ended up being even less than before 😱
fzaninotto
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
react-admin, errors might be objects withmessageandargsproperties which are used for translation.The original
final-form-submit-errorsmutator was considering those errors as form nested fields such asname.messageandname.args.I introduced our own version of this mutator which detects those objects.