Add ability to omit basePath in buttons #6041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Mar 15, 2021
| @@ -62,7 +62,9 @@ const getResourceLinkPath = ({ | |||
| ); | |||
| } | |||
| const sourceId = get(record, source); | |||
| const rootPath = basePath.replace(resource, reference); | |||
| const rootPath = basePath | |||
There was a problem hiding this comment.
this is a change I wanted to push in the previous PR, but @djhi was too fast to merge it
djhi
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the general case, we can infer the basePath from the resource, which is in the context.
<CardActions className={classes.cardActions}> - <EditButton - resource="posts" - basePath={basePath} - record={data[id]} - /> - <ShowButton - resource="posts" - basePath={basePath} - record={data[id]} - /> + <EditButton record={data[id]} /> + <ShowButton record={data[id]} /> </CardActions>