Fix ReferenceManyField renders too often #5612
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ReferenceManyField
rerenders whenever something in the resource changes. even unrelated changes like selected ids. This wastes CPU time and slows down List page interactions (a bit).Solution
Fix the data selector in
useGetMany
, which usesreselect
to memoize the result... But has a too broad dependency array.Before
Check the Tags column: all rows rerender when only one row is selected
After
Now only the selected row rerenders