Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set AutocompleteInput value to an empty string when it's selected item is null #4730

Merged
merged 2 commits into from
Apr 30, 2020

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Apr 27, 2020

Most AutocompleteInput tests threw console errors regarding initial state.

VM74:37 Warning: A component is changing a controlled input of type text to be uncontrolled. Input elements should not switch from controlled to uncontrolled (or vice versa). Decide between using a controlled or uncontrolled input element for the lifetime of the component. 

VM74:37 downshift: A component has changed the controlled prop "inputValue" to be - uncontrolled. This prop should not switch from controlled to uncontrolled (or vice versa). Decide - between using a controlled or uncontrolled Downshift element for the lifetime of the component. - More info: https://github.com/downshift-js/downshift#control-props 
     in Downshift (created by AutocompleteInput)
     in AutocompleteInput (at horascuentascorrientes.js:90)
    in HorasCCCreate (created by WithPermissions)
     in WithPermissions (created by Router.Consumer)
     in Router.Consumer (created by Route)
     in Route (created by ResourceRoutes)
     in ResourceRoutes (created by Resource)
     in Resource (at App.js:52)
     in App (at src/​index.js:20)

Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@djhi djhi added this to the 3.4.4 milestone Apr 28, 2020
@fzaninotto fzaninotto merged commit 9a5f1f1 into marmelab:master Apr 30, 2020
@fzaninotto
Copy link
Member

Thanks!

@WiXSL WiXSL deleted the fix-autocomplete-inputvalue branch April 30, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants