Add warning when leaving form with unsaved changes #4570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fzaninotto
commented
Mar 23, 2020
•
fzaninotto
commented
- Display warning when leaving form with unsaved changes
- Redisplay form with unsaved changes on cancel
- Make it work when the user navigates away from the form using the back button
- Add tests
- Add documentation
fzaninotto
force-pushed
the
warn-when-unsaved-changes
branch
from
2e187be to
fbdd737
Compare
fzaninotto
changed the title
fzaninotto
changed the title
fzaninotto
changed the title
djhi
requested changes
Mar 26, 2020
| @@ -90,6 +90,8 @@ const frenchMessages: TranslationMessages = { | |||
| not_found: | |||
| "L'URL saisie est incorrecte, ou vous avez suivi un mauvais lien.", | |||
| yes: 'Oui', | |||
| unsaved_changes: | |||
| "Certains changements n'ont pas été enregistrés. Etes-vous sûr(e) de vouloir quitter cette page ?", | |||
There was a problem hiding this comment.
Suggested change
| "Certains changements n'ont pas été enregistrés. Etes-vous sûr(e) de vouloir quitter cette page ?", | |
| "Certains changements n'ont pas été enregistrés. Êtes-vous sûr·e de vouloir quitter cette page ?", |
There was a problem hiding this comment.
we have "sûr(e)" already in other translations, let's keep parentheses for this one.
Co-Authored-By: Gildas Garcia <1122076+djhi@users.noreply.github.com>
Co-Authored-By: Gildas Garcia <1122076+djhi@users.noreply.github.com>
Co-Authored-By: Gildas Garcia <1122076+djhi@users.noreply.github.com>
djhi
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.