-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to keep form validation when using custom save buttons #4458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Mar 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be PRed against next
instead of master
JulienMattiussi
force-pushed
the
custom-submit-functions
branch
from
March 2, 2020 16:48
9ab6523
to
88b551f
Compare
JulienMattiussi
changed the title
Fix form validation when using custom save buttons
Allow to keep form validation when using custom save buttons
Mar 2, 2020
JulienMattiussi
added
RFR
Ready For Review
WIP
Work In Progress
and removed
WIP
Work In Progress
RFR
Ready For Review
labels
Mar 3, 2020
JulienMattiussi
force-pushed
the
custom-submit-functions
branch
from
March 4, 2020 09:49
cfef0c9
to
84dd489
Compare
fzaninotto
requested changes
Mar 4, 2020
JulienMattiussi
force-pushed
the
custom-submit-functions
branch
from
March 5, 2020 08:40
3d36a5d
to
3dc276e
Compare
JulienMattiussi
force-pushed
the
custom-submit-functions
branch
from
March 5, 2020 09:00
3dc276e
to
10759b5
Compare
fzaninotto
requested changes
Mar 5, 2020
fzaninotto
approved these changes
Mar 5, 2020
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4295
Issue
Form validation is never performed when using custom save buttons
(doing custom dava provider instead of dfault ra REST call)
Because when we overload handleSubmit or handleSubmitWithRedirect function, the form submission isn't performed
(And react-final-form doesn't offer a simple possibility to perform a form validation without a form submission.)
Solution
Add possibility to overload ra save function without overloading handleSubmit function
Use this
Instead of this
Doc