-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Autocomplete selection display with custom Component #4367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienMattiussi
changed the title
Autocomplete custom component
Fix Autocomplete selection display with custom Component
Jan 31, 2020
djhi
requested changes
Jan 31, 2020
Please target |
Co-Authored-By: Gildas Garcia <1122076+djhi@users.noreply.github.com>
fzaninotto
requested changes
Jan 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a check for the existence of an inputText
prop if the optionText
is a component, and throw an explicit error if it's not the case?
Co-Authored-By: Francois Zaninotto <francois@marmelab.com>
Co-Authored-By: Francois Zaninotto <francois@marmelab.com>
fzaninotto
approved these changes
Jan 31, 2020
This was referenced Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4281
Issue
When an autocomplete use a custom Component as
optionText
, The selected value can't be display in the filter TextField.Solution
When you want to pass a custom component as
optionText
to an Autocomplete,you also have to pass a text rendering function returning the filter text to be displayed for your custom component
This
inputText
function must return astring
which can be similary to the displayed component, or totally differentPreview
Documentation