Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double export (named and default) in component files #4254

Merged
merged 14 commits into from
Jan 8, 2020

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Jan 6, 2020

Fixes #4253.

@WiXSL
Copy link
Contributor Author

WiXSL commented Jan 6, 2020

I've reverted changes of some components, because their tests failed when importing the default version which is a recompose.pure or recompose.shouldComponentUpdate version of them.

May be I could change that for React.memo in another PR.

Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some cases (e.g. ArrayField) where the named export and the default export weren't the same thing, because there is still a HOC. Please revert the changes for these - the named export is useful for tests.

@WiXSL
Copy link
Contributor Author

WiXSL commented Jan 7, 2020

Done!

@WiXSL WiXSL requested a review from fzaninotto January 7, 2020 09:02
@ThieryMichel ThieryMichel added this to the 3.1.2 milestone Jan 8, 2020
@ThieryMichel ThieryMichel changed the title Remove components named exports in favor of the default ones. Fix Remove redundant components named exports in favor of the default ones. Jan 8, 2020
@ThieryMichel ThieryMichel merged commit 9455dc8 into marmelab:master Jan 8, 2020
@fzaninotto fzaninotto changed the title Fix Remove redundant components named exports in favor of the default ones. Fix double export (named and default) in component files Jan 8, 2020
@fzaninotto
Copy link
Member

Thanks!

@WiXSL WiXSL deleted the patch-components-exported-twice branch January 8, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components exported twice
3 participants