Fix hot reload for demo example #4252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThieryMichel
changed the title
|
can't the |
Sadly no, the demo use the builded module, and so even linked we still need to build the module. Which is already the case without link. |
ThieryMichel
force-pushed
the
demo_dev
branch
from
5f4ccc6 to
5e019f0
Compare
ThieryMichel
added
RFR
|
The correct solution was to build the packages in watch mode while launching the demo, lerna does the rest. |
ThieryMichel
commented
Feb 5, 2020
| @@ -24,7 +24,7 @@ | |||
| "build": "yarn run build-cjs && yarn run build-esm", | |||
| "build-cjs": "rimraf ./lib && tsc", | |||
| "build-esm": "rimraf ./esm && tsc --outDir esm --module es2015", | |||
| "watch": "rimraf ./lib && tsc --watch" | |||
There was a problem hiding this comment.
the demo need the esm package.
fzaninotto
approved these changes
Feb 12, 2020
fzaninotto
changed the title
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.