Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix withTranslate HOC uses default translate prop instead of the one from context #4233

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Fix withTranslate HOC uses default translate prop instead of the one from context #4233

merged 1 commit into from
Jan 3, 2020

Conversation

ThieryMichel
Copy link
Contributor

fix #4208

In translate hoc prevent component props to overrides injected translate and locale.

@ThieryMichel ThieryMichel added the RFR Ready For Review label Jan 2, 2020
@fzaninotto fzaninotto changed the title fix translate hoc Fix withTranslate HOC uses defualt translate prop instead of the one from context Jan 3, 2020
@fzaninotto fzaninotto merged commit efb332c into master Jan 3, 2020
@fzaninotto fzaninotto added this to the 3.1.2 milestone Jan 3, 2020
@fzaninotto fzaninotto deleted the fix_translate_hoc branch January 3, 2020 15:55
@fzaninotto fzaninotto changed the title Fix withTranslate HOC uses defualt translate prop instead of the one from context Fix withTranslate HOC uses default translate prop instead of the one from context Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.

Translate defaultProps not working as before for class component
2 participants
@ThieryMichel @fzaninotto