Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings caused by passing new FinalForm form state property 'dirty… #3959

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

MiMo42
Copy link
Contributor

@MiMo42 MiMo42 commented Nov 8, 2019

Warning: React does not recognize the dirtyFieldsSinceLastSubmit prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase dirtyfieldssincelastsubmit instead. If you accidentally passed it from a parent component, remove it from the DOM element.

Theres a new form state related property 'dirtyFieldsSinceLastSubmit' in new FinalForm 4.18.6 (has been released yesterday).
It is currently passed to form because it is not sanitized yet.
This PR sanitizes it in react-admin forms.

…FieldsSinceLastSubmit' to form.

See FinalForm 4.18.6
@MiMo42 MiMo42 changed the title Fix errors caused by passing new FinalForm form state property 'dirty… Fix warnings caused by passing new FinalForm form state property 'dirty… Nov 8, 2019
@djhi djhi added this to the 3.0.0 milestone Nov 8, 2019
@djhi
Copy link
Collaborator

djhi commented Nov 8, 2019

Thanks!

@djhi djhi merged commit 9551eb8 into marmelab:next Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants