[RFR] Remove duplicate API call in ReferenceArrayInput #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fargito
changed the title
AleBlondin
reviewed
May 20, 2019
packages/ra-core/src/controller/input/ReferenceArrayInputController.tsx
Outdated
Show resolved
Hide resolved
fargito
force-pushed
the
remove-duplicate-api-call
branch
from
209ac6a to
842fa19
Compare
fargito
changed the title
packages/ra-core/src/controller/input/ReferenceArrayInputController.tsx
Outdated
Show resolved
Hide resolved
djhi
requested changes
May 22, 2019
fargito
force-pushed
the
remove-duplicate-api-call
branch
from
842fa19 to
0dea6c4
Compare
|
@djhi is it ok for you ? :) |
|
Looks good but I won't have time to test it before next week. I'm at react europe |
fzaninotto
changed the title
fzaninotto
requested changes
May 23, 2019
packages/ra-core/src/controller/input/ReferenceArrayInputController.tsx
Outdated
Show resolved
Hide resolved
packages/ra-core/src/controller/input/ReferenceArrayInputController.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ra-core/src/controller/input/ReferenceArrayInputController.tsx
Outdated
Show resolved
Hide resolved
fargito
force-pushed
the
remove-duplicate-api-call
branch
from
b320769 to
9415b04
Compare
djhi
approved these changes
Jun 5, 2019
fzaninotto
approved these changes
Jun 5, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3108