[RFR] Reference hooks #3228
Merged
[RFR] Reference hooks #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
reviewed
May 15, 2019
| import { crudGetManyAccumulate as crudGetManyAccumulateAction } from '../../actions'; | ||
| import { linkToRecord } from '../../util'; | ||
| import { Record, Dispatch } from '../../types'; | ||
| import { SFC, ReactNode, ReactElement } from 'react'; |
There was a problem hiding this comment.
I think they renamed SFC into FunctionalComponent in the latest typings. Probably not a good idea to upgrade the typings in this PR though
There was a problem hiding this comment.
For reference: DefinitelyTyped/DefinitelyTyped#30364
djhi
requested changes
May 15, 2019
| @@ -65,7 +65,7 @@ describe('ListController', () => { | |||
|
|
|||
| const { getByLabelText } = render( | |||
| <TestContext | |||
| store={{ | |||
| initialState={{ | |||
There was a problem hiding this comment.
Why don't you use your shiny new renderWithRedux ? Same for all tests using TestContext
There was a problem hiding this comment.
I was afraid of the potential rebase ....
fzaninotto
requested changes
May 15, 2019
5 tasks
fzaninotto
approved these changes
May 16, 2019
djhi
approved these changes
May 16, 2019
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor ReferenceFieldController using hooks and introduce useReference hooks.
ReferenceMany will follow.