-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SimpleFormIterator] add TransitionProps prop #3226
[SimpleFormIterator] add TransitionProps prop #3226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! As this is a new feature, can you target the next
branch?
@@ -115,6 +115,7 @@ export class SimpleFormIterator extends Component { | |||
translate, | |||
disableAdd, | |||
disableRemove, | |||
TransitionProps, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename it to transitionProps
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used material-ui naming pattern here - see ExpansionPanel
TransitionProps
- https://material-ui.com/api/expansion-panel/#props
Maybe it's worth to stick with it?
From component's API perspective, it's indeed a new feature. I'll change target branch to |
Ok, can you wait for @fzaninotto review then before switching branch ? |
@djhi sure |
It's indeed a new feature, please PR against |
Any news on this one? |
Thanks! |
This PR adds ability to override
CSSTransition
props.Together with #3223 adds ability to workaround #3220 in user land:
May be worth to decrease default timeout in the future, but adding ability for workaround is a good first step.