[RFR] Fix sending request by Query with deep props on every update #3176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PPierzc
changed the title
PPierzc
changed the title
fzaninotto
requested changes
May 7, 2019
| @@ -1,5 +1,5 @@ | |||
| import { Component, ReactNode } from 'react'; | |||
| import { shallowEqual } from 'recompose'; | |||
| import equal from 'deep-equal'; | |||
There was a problem hiding this comment.
deep-equal isn't a direct dependency. use lodash/isEqual instead
|
Any update? |
|
Superseded by #3267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed shallowEqual to deepEqual in Query to accommodate for possible deep props.
Changed the placement of
myPayloadvariable.When
myPayloadis global the objects are indeed identical and the script worked did pass. However, this assumes independency from props, which is not desired. This can easily lead to endless loops.Solves #3174