Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Relax react router dependency to avoid version mismatch #3144

Merged
merged 1 commit into from
Apr 19, 2019
Merged

[RFR] Relax react router dependency to avoid version mismatch #3144

merged 1 commit into from
Apr 19, 2019

Conversation

fzaninotto
Copy link
Member

Closes #3138

@fzaninotto
Copy link
Member Author

The warnings come from history, which is a dependency of react-router-dom. history is resolved to the latest version (4.9.0) on new projects. It complains that react-router-dom uses an outdated way of calling the history adapters. The fix consists of relaxing the react-router-dom version constraint, to have a more recent version that calls history adapters the right way.

@djhi djhi added this to the 2.8.6 milestone Apr 19, 2019
@djhi djhi merged commit eff280e into master Apr 19, 2019
@djhi djhi deleted the fix-react-router-warnings branch April 19, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.6
Development

Successfully merging this pull request may close these issues.

require("history") console warnings
2 participants
@fzaninotto @djhi