add missing dependencies

[cortopy]

I've added a few dependencies missing from packages. Not having these dependencies breaks installations with pnpm, requiring a fix on behalf of the developer

[fzaninotto]

what's pnpm? What's the error and the project setup?

[djhi]

pnpm is an alternative to npm and yarn: https://github.com/pnpm/pnpm

[fzaninotto]

Well, if it's not compatible with npm and yarn, I don't see why we should make changes in the react-admin codebase to support it.

[kopax]

@fzaninotto pnpm is a replacement, a 3rd package manager choice for all developers (like yarn). We use npm for that reason, even if yarn is more convenient on many points.

I found it dubious that pnpm force package maintainer to list in package.json dependencies that are actually not used in the code base of the distributed module and:

ra-core

• history: https://github.com/marmelab/react-admin/blob/master/packages/ra-core/src/util/TestContext.tsx#L7

ra-ui-materialui

• react-router: https://github.com/marmelab/react-admin/blob/master/packages/ra-ui-materialui/src/layout/Layout.js#L5
• react-router-redux: https://github.com/marmelab/react-admin/blob/master/packages/ra-ui-materialui/src/list/DatagridRow.js#L5

This should be merged. If it was working, that's only because dependencies listed in their respective package.json were bringing those dependencies in the dependency resolution system, but that's still wrong.

I recommend this no-extraneous-dependencies linting rule, that could be added to prevent such mistakes in the future. Maybe @cortopy can add it in this PR?

[cortopy]

@fzaninotto it is compatible with npm and yarn. But it was created with two aims in mind:

• performance
• solve doppelgangers that both npm and yarn suffer from

It's the default package manager in rush for these reasons

[cortopy]

@kopax I don't use those plugins as I have come to rely on pnpm to tell me about phantom dependencies. Could add it if needed though

[fzaninotto]

@kopax thanks for the clarification and the links, now I understand.

@cortopy I'd gladly merge another PR adding the linter rule to prevent such problems in the future.