-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IE11 layout problem caused by flex-basis: auto
#2763
Conversation
beab316
to
380b671
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This needs thorough testing across multiple browsers |
@fzaninotto of course — how would you like me to proceed? |
We use tools like BrowserStack. But I'll do the tests on this one to make sure it breaks nothing - we've had regressions in the past due to small changes in the layout CSS. |
@fzaninotto Hi! Did you have time to run some browser testing on this issue? Let me know if I can be of any help 🙂 |
@fzaninotto Hi! Do you think you will have some time to test this PR soon? cc @Kmaschta Thanks! |
I booked 15min tomorrow to test that branch locally with Browserstack |
@Kmaschta thanks for the review! @fzaninotto Do you think this PR can make it for the |
@fzaninotto Oops, I can work on it next week, will keep you updated! |
As mentioned in #2676, IE11 suffers from several layout problems where the user would have to horizontally scroll to see all content and/or images would get absurdly distorted.
philipwalton/flexbugs#170 seems to show that IE11 shows inconsistency when using
flex-basis: auto
(or the shorthand version:flex: X Y auto
).I tried changing
auto
by0px
in such statements, and it looks like it fixed many of those layout problems in the demo app:I also had to remove the
display: flex
andflex-wrap: wrap
onSegmentsField
because IE11 has many problems withflex-wrap: wrap
. The wrapping still works (Chrome + IE11) though.Navigating the demo app on Chrome showed me no visual regression, and
<Aside />
components (for which theflex-basis: auto
were introduced) still work as expected: