render children inside AppBar

[astiag]

this PR will render children inside AppBar component

[fzaninotto]

please add documentation and example usage

[alanpoulain]

Related to this: #2534

[fzaninotto]

Let me rephrase my remark: please add documentation and example usage in the files of your PR (i.e. modify the react-admin documentation, not only the code).

[alanpoulain]

I can but I am not the author of this PR 😅

[astiag]

I know your rules about having everything documented.
but the thing is you already have it here

btw your docs regarding to adding children to AppBar will cause some problems

const MyAppBar = props => (
    <AppBar {...props}>
        <Toolbar>
            <Typography variant="title" id="react-admin-title" />
        </Toolbar>
    </AppBar>
);

in this case you will have Toolbar inside Toolbar. see here

so I also will fix this one in a new commit in this PR

[alanpoulain]

@astiag No I don't think it's the case. You are mixing up AppBar from @material-ui and AppBar from ra-ui-materialui. The first can take children (and a Toolbar), the second can't.

[astiag]

@alanpoulain you are right. didnt notice that.
anyway I'll add something in documents about having children inside AppBar

[astiag]

@fzaninotto please review again

[djhi]

This should probably go inside the Using a Custom AppBar section.

[fzaninotto]

👍

[astiag]

will change it asap

[astiag]

done

[fzaninotto]

Any progress?

[BartoGabriel]

I think it would be good to combine this feature, with the possibility of disabling the LoadingIndicator or the UserMenu of the AppBar.
Since the user having the ability to customize AppBar, he could create their own components, without having to make a new AppBar.
With two properties it could be solved.

[astiag]

Any progress?

@fzaninotto @djhi I've moved the description to Using a Custom AppBar section

[fzaninotto]

Thanks for the PR, I've finally decided to do a slightly different implementation (replacing the content with children instead of appending the children to the default content) in #2777. So I'll close this PR.