[RFR] Fix create to edit form values #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
reviewed
Sep 19, 2018
| import { LOCATION_CHANGE } from 'react-router-redux'; | ||
| import { beforeLocationChange } from '../actions/formActions'; | ||
|
|
||
| const formMiddleware = () => next => action => { |
There was a problem hiding this comment.
I and other developers will be unable to understand why you're doing that. This file requires many, many comments to describe the issue and the solution.
djhi
force-pushed
the
fix-create-edit-form-values
branch
from
a1a93bc to
cc16e80
Compare
djhi
force-pushed
the
fix-create-edit-form-values
branch
3 times, most recently
from
a8abdc7 to
db7b3c3
Compare
djhi
force-pushed
the
fix-create-edit-form-values
branch
from
db7b3c3 to
d9b45d2
Compare
djhi
changed the title
|
Oh no, now that it is RFR and green, that's the moment you say "Can you target next?", right @fzaninotto? 😭 |
fzaninotto
requested changes
Sep 20, 2018
| * | ||
| * A middleware is needed instead of a saga because we need to control the actions | ||
| * order: we need to ensure we reset the redux form BEFORE the location actually | ||
| * change. Otherwise, the new page which may contains a record redux-form might |
There was a problem hiding this comment.
s/change/changes/
s/may contains/may contain/
As requested by fzaninotto at #2339 (comment)
As requested by fzaninotto at #2339 (comment)
Actually the |
fzaninotto
approved these changes
Sep 20, 2018
|
Awesome, this makes it a non-BC break change, and therefore totally worthy of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2324