Add support for React 19 #10437
Add support for React 19 #10437
Conversation
packages/ra-ui-materialui/src/input/ArrayInput/ArrayInput.spec.tsx
Outdated
Show resolved
Hide resolved
| "little-state-machine": "^4.8.1", | ||
| "react-simple-animate": "^3.5.3", |
There was a problem hiding this comment.
Had to add those manually (hookform devtools depends on them) to have react-19 support
| @@ -4761,13 +4690,34 @@ __metadata: | |||
| languageName: node | |||
| linkType: hard | |||
|
|
|||
| "@types/d3-array@npm:^3.0.3": | |||
There was a problem hiding this comment.
There are a bunch of duplicates I can't resolve here with d3. This is because of recharts and one of its dependency (victory) that have conflicting types deps
| @@ -47,7 +47,7 @@ const App = () => { | |||
| const darkTheme = themes.find(theme => theme.name === themeName)?.dark; | |||
| return ( | |||
| <Admin | |||
| title="" | |||
| title="Posters Galore Admin" | |||
There was a problem hiding this comment.
Added to access it in custom titles
| const pageTitle = translate('ra.page.edit', { | ||
| name: getResourceLabel('categories', 1), | ||
| recordRepresentation: `"${record?.name}"`, | ||
| }); |
There was a problem hiding this comment.
I did not use usePageTitle here because we want the quotes around the name in titles but not in the record representation
| const pageTitle = translate('ra.page.edit', { | ||
| name: getResourceLabel('products', 1), | ||
| recordRepresentation: `"${record?.reference}"`, | ||
| }); |
There was a problem hiding this comment.
I did not use usePageTitle here because we want the quotes around the reference in titles but not in the record representation
| @@ -121,6 +122,7 @@ export const SimpleList = <RecordType extends RaRecord = any>( | |||
| rowClick={rowClick} | |||
| rowSx={rowSx} | |||
| rowStyle={rowStyle} | |||
| resource={resource} | |||
There was a problem hiding this comment.
This fixes an issue we somehow missed before: SimpleList was not propagating its resource prop
Problem
React 19 is out !
Solution
Add support for React 19. Requires to upgrade MUI to latest v5.
TODO
react-isHow To Test
Additional Checks
masterfor a bugfix, ornextfor a feature