Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Remove <ShowBase emptyWhileLoading> from the docs #10416

Merged
merged 1 commit into from
Dec 16, 2024
Merged

[Doc] Remove <ShowBase emptyWhileLoading> from the docs #10416

merged 1 commit into from
Dec 16, 2024

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Dec 16, 2024

Problem

Fix #10411

Solution

Remove section documenting <ShowBase emptyWhileLoading> from the docs since the prop does not exist.

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

@slax57 slax57 added the RFR Ready For Review label Dec 16, 2024
@djhi djhi added this to the 5.4.3 milestone Dec 16, 2024
@djhi djhi merged commit 526d088 into master Dec 16, 2024
15 checks passed
@djhi djhi deleted the doc-ShowBase-emptyWhileLoading branch December 16, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
5.4.3
Development

Successfully merging this pull request may close these issues.

Contrary to the docs, ShowBase does not accept emptyWhileLoading
2 participants
@slax57 @djhi