Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access control basename handling #10383

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Nov 26, 2024

Problem

When using the basename prop on <Admin>, access control redirects don't work.
Also, ResourceMenuItem should not render in case of access control error

Fixes #10380

Solution

  • Use the basename in those redirects.
  • Fix ResourceMenuItem should not render in case of access control error

How To Test

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

@djhi djhi added RFR Ready For Review WIP Work In Progress and removed RFR Ready For Review labels Nov 26, 2024
@fzaninotto fzaninotto merged commit bf2c145 into master Nov 26, 2024
15 checks passed
@fzaninotto fzaninotto deleted the fix-access-control-basename-handling branch November 26, 2024 14:46
@fzaninotto fzaninotto added this to the 5.4.1 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access control redirects don't respect basename when react-admin included inside a route
2 participants