Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Update useUpdate doc to explain returnPromise option #10372

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[Doc] Update useUpdate doc to explain returnPromise option #10372

merged 1 commit into from
Nov 22, 2024

Conversation

fzaninotto
Copy link
Member

No description provided.

@fzaninotto fzaninotto added the RFR Ready For Review label Nov 21, 2024
djhi
djhi reviewed Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we have many such examples, but shouldn't we make them closer to real world usage (inside a custom button, etc)?

@fzaninotto
Copy link
Member Author

I know we have many such examples, but shouldn't we make them closer to real world usage (inside a custom button, etc)?

This is the closest to real world usage I could find.

@djhi
Copy link
Collaborator

djhi commented Nov 22, 2024

I know we have many such examples, but shouldn't we make them closer to real world usage (inside a custom button, etc)?

This is the closest to real world usage I could find.

I meant have a real button with JSX and imports

@fzaninotto
Copy link
Member Author

I know we have many such examples, but shouldn't we make them closer to real world usage (inside a custom button, etc)?

This is the closest to real world usage I could find.

I meant have a real button with JSX and imports

IMHO it dilutes the example. In addition, we don't do it for the other options.

@djhi djhi added this to the 5.4.1 milestone Nov 22, 2024
@djhi djhi merged commit 2037cb5 into master Nov 22, 2024
15 checks passed
@djhi djhi deleted the doc-useUpdate-returnPromise branch November 22, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi left review comments

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
5.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@fzaninotto @djhi @slax57