Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SortButton default translation #10368

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Fix SortButton default translation #10368

merged 1 commit into from
Nov 21, 2024

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Nov 20, 2024

Before

image

This is a regression caused by #10337

After

image

How to test

  • Launch the ecommerce demo
  • Go to the posters list
  • See the sort button

Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we add a test for this?

@djhi djhi added this to the 5.4.0 milestone Nov 21, 2024
@djhi djhi merged commit 1f4b1de into master Nov 21, 2024
15 checks passed
@djhi djhi deleted the fix-sort-button-translation branch November 21, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants