feat(ra-core): remove useSafeSetState hook #10341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geobde
changed the title
geobde
changed the title
erwanMarmelab
requested changes
Nov 13, 2024
fzaninotto
requested changes
Nov 13, 2024
fzaninotto
requested changes
Nov 14, 2024
fzaninotto
approved these changes
Nov 14, 2024
djhi
approved these changes
Nov 14, 2024
No, react-admin v5 requires React 18. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
useSafeSetStatehook was previously used to prevent warnings when attempting to call setState on unmounted components. However, with React 18 changes the use of this hook has become unnecessary and leads to unnecessary complexity.Solution
Replaced the
useSafeSetStatehook with theReact.useState. Since React no longer issues warnings when calling setState on unmounted components.Context
Update to remove the "setState on unmounted component" warning
Closes #10323