fixes #10301 race condition in link generation #10304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. I have created another one with a proper test to demonstrate the fix. |
quentin-decre
pushed a commit
to quentin-decre/react-admin
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Describe the problem this PR solves
fixes an issue (race condition) happening during reference link generation
bug introduced in 5.2.3 -> 5.3.0
10a1c76
The issue is somewhat described in
#10301
Closes #10301
Solution
pathis notsetwhen asyncrecordcomes in andlinkprop is astringHow To Test
I hope it's clear that the
useEffectshould set this