Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double decoding of ids in URLs #10293

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Fix double decoding of ids in URLs #10293

merged 2 commits into from
Oct 24, 2024

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Oct 22, 2024

Problem

Fixes #10158. React-router fixed an issue where params weren't properly decoded. However, react-admin still tried to decode them, leading to invalid ids.

Solution

Remove the decoding from useEditController and useShowController

How To Test

There are new stories and tests

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

@djhi djhi added the WIP Work In Progress label Oct 22, 2024
@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels Oct 22, 2024
@slax57 slax57 self-requested a review October 23, 2024 14:53
slax57
slax57 requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that it looks good!

packages/ra-core/src/controller/edit/useEditController.stories.tsx Show resolved Hide resolved
packages/ra-core/src/controller/show/useShowController.stories.tsx Show resolved Hide resolved
@slax57 slax57 added this to the 5.3.1 milestone Oct 24, 2024
@slax57 slax57 merged commit 0d1e162 into master Oct 24, 2024
15 checks passed
@slax57 slax57 deleted the fix-double-decoding-ids branch October 24, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
5.3.1
Development

Successfully merging this pull request may close these issues.

Getting URI malformed when trying to edit record with percentage (%) symbol in.
2 participants
@djhi @slax57