-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce <NavigateToFirstResource>
#10255
Merged
fzaninotto
merged 7 commits into
access-control-resources
from
access-control-first-resource
Oct 3, 2024
Merged
Introduce <NavigateToFirstResource>
#10255
fzaninotto
merged 7 commits into
access-control-resources
from
access-control-first-resource
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
Co-authored-by: Francois Zaninotto <francois@marmelab.com>
…eact-admin into access-control-first-resource
fzaninotto
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the absence of a dashboard component, the
/
route redirects to thelist
view of the first Resource (or the first availablelist
view of all resources).With the introduction of
canAccess
, this may lead to an Access Denied page. For instance, if the first resource is a posts list, and the connected user doesn't have the{ action: "list", resource: "posts" }
permission, they will see the access denied page.Solution
/
routeThis 2. is a slight BC break. In the case of a default
list
view withdisableAuthentiction
turned on, anonymous users won't be able to access it. It's an easy fix though: set the<Admin dashboard>
to a<Navigate>
component to bypass the default route selection.Additional Checks
master
for a bugfix, ornext
for a feature