Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update <Filterbutton>'s screencast #10213

Merged
merged 4 commits into from
Oct 1, 2024
Merged

[Doc] Update <Filterbutton>'s screencast #10213

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9cd69b
remove useless gif
erwanMarmelab Sep 17, 2024
c3a8c0c
create new screencast
erwanMarmelab Sep 17, 2024
02ee9f0
Update imports
erwanMarmelab Sep 17, 2024
bb59c7b
fix video speed
erwanMarmelab Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/Buttons.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,6 @@ However since we are in the context of a list, there is no `<RecordContext>` ava
This button is an internal component used by react-admin in [the Filter button/form combo](./FilteringTutorial.md#the-filter-buttonform-combo).

<video controls autoplay playsinline muted loop>
<source src="./img/list_filter.webm" type="video/webm"/>
<source src="./img/list_filter.mp4" type="video/mp4"/>
Your browser does not support the video tag.
</video>
Expand Down
3 changes: 1 addition & 2 deletions docs/Features.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,9 +421,8 @@ In most admin and B2B apps, the most common task is to look for a record. React-
<table><tbody>
<tr style="border:none">
<td style="width:50%;border:none;text-align:center">
<a title="Filter Button/Form Combo" href="./img/list_filter.webm">
<a title="Filter Button/Form Combo" href="./img/list_filter.mp4">
<video controls autoplay playsinline muted loop>
<source src="./img/list_filter.webm" type="video/webm"/>
<source src="./img/list_filter.mp4" type="video/mp4"/>
Your browser does not support the video tag.
</video>
Expand Down
1 change: 0 additions & 1 deletion docs/FilterButton.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ title: "The FilterButton Component"
Part of the filter button/form combo, `<FilterButton>` renders whenever you use the `<List filters>` prop. When clicked, it reveals a dropdown of filter names, allowing users to add a new filter input to the filter form.

<video controls autoplay playsinline muted loop>
<source src="./img/list_filter.webm" type="video/webm"/>
<source src="./img/list_filter.mp4" type="video/mp4"/>
Your browser does not support the video tag.
</video>
Expand Down
1 change: 0 additions & 1 deletion docs/FilterForm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ title: "The FilterForm Component"
Part of the filter button/form combo, `<FilterForm>` renders whenever you use the `<List filters>` prop. It renders the filter inputs that are `alwaysOn`, and the ones that were enabled by the user by using the `<FilterButton>`. The `<FilterForm>` has no submit button: it modifies the list filters as the user types in the form (with a debounce to avoid too many requests).

<video controls autoplay playsinline muted loop>
<source src="./img/list_filter.webm" type="video/webm"/>
<source src="./img/list_filter.mp4" type="video/mp4"/>
Your browser does not support the video tag.
</video>
Expand Down
4 changes: 1 addition & 3 deletions docs/FilteringTutorial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@ One of the most important features of the List page is the ability to filter the
<table><tbody>
<tr style="border:none">
<td style="width:50%;border:none;text-align:center">
<a title="Filter Button/Form Combo" href="./img/list_filter.webm">
<a title="Filter Button/Form Combo" href="./img/list_filter.mp4">
<video controls autoplay playsinline muted loop>
<source src="./img/list_filter.webm" type="video/webm"/>
<source src="./img/list_filter.mp4" type="video/mp4"/>
Your browser does not support the video tag.
</video>
Expand Down Expand Up @@ -57,7 +56,6 @@ React-admin offers 4 different ways to filter the list. Depending on the type of
## The Filter Button/Form Combo

<video controls autoplay playsinline muted loop>
<source src="./img/list_filter.webm" type="video/webm"/>
<source src="./img/list_filter.mp4" type="video/mp4"/>
Your browser does not support the video tag.
</video>
Expand Down
1 change: 0 additions & 1 deletion docs/List.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,6 @@ const CommentList = () => (
## `filters`: Filter Inputs

<video controls autoplay playsinline muted loop>
<source src="./img/list_filter.webm" type="video/webm"/>
<source src="./img/list_filter.mp4" type="video/mp4"/>
Your browser does not support the video tag.
</video>
Expand Down
1 change: 0 additions & 1 deletion docs/ListTutorial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,6 @@ React-admin provides 2 possible UIs for filters, and lets your own if they're no
The first filter UI is called "the Filer/Form Combo".

<video controls autoplay playsinline muted loop>
<source src="./img/list_filter.webm" type="video/webm"/>
<source src="./img/list_filter.mp4" type="video/mp4"/>
Your browser does not support the video tag.
</video>
Expand Down
Binary file removed docs/img/list_filter.gif
View file
Open in desktop
Binary file not shown.
Binary file modified docs/img/list_filter.mp4
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with this video. It's excrutiatingly slow. Also, the example doesn't make sense. A filter "bar" on the "nested" field?? I suggest you follow the exact same scenario as the original.

Binary file not shown.
Binary file removed docs/img/list_filter.webm
View file
Open in desktop
Binary file not shown.
Loading