Documented theme level defaultProps overrides do not work for react admin components

[wattry]

What you were expecting:
We use medium size buttons for our custom filter components and the FilterButton component which uses an RA Button which defaults the size to small. This means we cannot use the MUI defaultProps to override it at a theme level and it does not take a size prop. The RA upgrading to v4 docs state that you can override the defaultProps on RA components, however, this does not seem to be work as I tried the example provided RaTextInput and this issue states that it won't be implemented.

You can find the reference to where it is documented here, I'm not sure if the position has changed or the RA Button does not allow for it. Since upgrading to RA4 we've tried to avoid creating too many wrapped copies unless necessary, since it made the upgrade considerably more work.

** Related Code **

Button.ts:39

Environment

• React-admin version: 4.16.1
• React version: 17.0.2

[fzaninotto]

The migration documentation you're referring to (https://marmelab.com/react-admin/Upgrade.html#simpleform-and-tabbedform-no-longer-accept-margin-and-variant) explains that you can apply custom props on the MuiTextField. This works. Can you confirm it?

We probably need to remove the mention of overriding RaTextInput default props as it's not working. Marking this as a documentation issue.

[wattry]

I'll be specific to the component we're attempting to override. RA Button

const {
        alignIcon = 'left',
        children,
        className,
        disabled,
        label,
        color = 'primary',
        size = 'small',
        to: locationDescriptor,
        ...rest
    } = props;

Since the props are being provided as overrides here MUI does not use the defaultProps defined in the theme. You can see this working for color on the columns button, as it does not set a default color, however the rest of the toolbar does. So the color override works and the size does not.

Stackblitz example can be found in the index

[fzaninotto]

@wattry concerning the ability to override react-admin components, it's not possible without a breaking change (cf #9546). We're preparing v5, so it's the right time to work on that. I suggest you open a new issue about it.

[wattry]

@fzaninotto we were more interested in if we were misinterpreting the documentation or if that component wasn't implemented to use RA overrides. We've managed thus far and since it's in RA5 is on the horizon, I'm not going to request your teams resources to update this.