Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example code in documentation does not work #4329

Closed
elsni opened this issue Jan 21, 2020 · 1 comment · Fixed by #4335
Closed

Example code in documentation does not work #4329

elsni opened this issue Jan 21, 2020 · 1 comment · Fixed by #4335
Assignees
@fzaninotto
Labels
documentation

Comments

@elsni
Copy link

elsni commented Jan 21, 2020

On this documentation Page
https://marmelab.com/react-admin/CreateEdit.html#customizing-the-form-layout
The Example code in subsection "formClassName" does not work: makeStyles() is undefined.
@fzaninotto fzaninotto self-assigned this Jan 21, 2020
@fzaninotto
Copy link
Member

I pushed the fix to master by mistake. I've reverted 3355f1d in c32471d, and I'm reopening this issue to propose the fix in a PR instead.

@fzaninotto fzaninotto reopened this Jan 21, 2020
fzaninotto added a commit that referenced this issue Jan 21, 2020
@fzaninotto
Fix form customization code snippet in CreateEdit documentation
8d8979e 
Closes #4329
@fzaninotto fzaninotto mentioned this issue Jan 21, 2020
Merged
JulienMattiussi pushed a commit that referenced this issue Jan 28, 2020
@fzaninotto @JulienMattiussi
Fix form customization code snippet in CreateEdit documentation
cbfdc11 
Closes #4329
JulienMattiussi pushed a commit that referenced this issue Jan 28, 2020
@fzaninotto @JulienMattiussi
Fix form customization code snippet in CreateEdit documentation
71407dc 
Closes #4329
JulienMattiussi pushed a commit that referenced this issue Jan 31, 2020
@fzaninotto @JulienMattiussi
Fix form customization code snippet in CreateEdit documentation
aca8d8f 
Closes #4329
JulienMattiussi pushed a commit that referenced this issue Jan 31, 2020
@fzaninotto @JulienMattiussi
Fix form customization code snippet in CreateEdit documentation
e9322ae 
Closes #4329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fzaninotto fzaninotto

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix form customization code snippet in CreateEdit documentation marmelab/react-admin
2 participants
@fzaninotto @elsni