Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support row expansion on DataGrid row-click #2765

Closed
kdabir opened this issue Jan 14, 2019 · 3 comments
Closed

Support row expansion on DataGrid row-click #2765

kdabir opened this issue Jan 14, 2019 · 3 comments
Assignees
@fzaninotto
Labels
enhancement

Comments

@kdabir
Copy link

kdabir commented Jan 14, 2019

Is your feature request related to a problem? Please describe.
Currently, rowClick supports show|edit as possible action on click of DataGrid row.

Describe the solution you'd like
Please consider supporting additional option value expand which is will expand the row.

<Datagrid rowClick="expand" expand={<GroupExpansion/>}>

Additional context
Row Expansion was a feature introduced in 2.6.
@kdabir kdabir changed the title Support expand on DataGrid row click Support row expand on DataGrid row-click Jan 14, 2019
@kdabir kdabir changed the title Support row expand on DataGrid row-click Support row expansion on DataGrid row-click Jan 14, 2019
@fzaninotto
Copy link
Member

Nice suggestion. We won't implement it ourselves as we don't need it, so feel free to open a PR about it.

@fzaninotto fzaninotto self-assigned this Jan 28, 2019
@fzaninotto
Copy link
Member

It turns out we do need it now ;)

fzaninotto added a commit that referenced this issue Jan 28, 2019
@fzaninotto
Add support for rowClick="expand" in Datagrid
d02111f 
Closes #2765
@fzaninotto fzaninotto mentioned this issue Jan 28, 2019
Merged
@fzaninotto
Copy link
Member

Fixed by #2820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fzaninotto fzaninotto

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fzaninotto @kdabir