Ensure children is required on controllers

marmelab · Jun 15, 2019 · e6083f8 · e6083f8
1 parent a2acace
commit e6083f8
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 15 deletions.
diff --git a/packages/ra-core/src/controller/CreateController.tsx b/packages/ra-core/src/controller/CreateController.tsx
@@ -80,7 +80,7 @@ interface Props {
 const CreateController = (props: Props) => {
     useCheckMinimumRequiredProps(
         'Create',
-        ['basePath', 'location', 'resource'],
+        ['basePath', 'location', 'resource', 'children'],
         props
     );
     const {
@@ -107,10 +107,6 @@ const CreateController = (props: Props) => {
         [resource, basePath] // eslint-disable-line react-hooks/exhaustive-deps
     );
 
-    if (!children) {
-        return null;
-    }
-
     const resourceName = translate(`resources.${resource}.name`, {
         smart_count: 1,
         _: inflection.humanize(inflection.singularize(resource)),

diff --git a/packages/ra-core/src/controller/EditController.tsx b/packages/ra-core/src/controller/EditController.tsx
@@ -81,7 +81,7 @@ interface Props {
  *     export default App;
  */
 const EditController = (props: Props) => {
-    useCheckMinimumRequiredProps('Edit', ['basePath', 'resource'], props);
+    useCheckMinimumRequiredProps('Edit', ['basePath', 'resource', 'children'], props);
     const { basePath, children, id, resource, undoable } = props;
     const translate = useTranslate();
     const dispatch = useDispatch();
@@ -133,10 +133,6 @@ const EditController = (props: Props) => {
         [resource, id, record, basePath, undoable] // eslint-disable-line react-hooks/exhaustive-deps
     );
 
-    if (!children) {
-        return null;
-    }
-
     return children({
         isLoading: loading,
         defaultTitle,

diff --git a/packages/ra-core/src/controller/ListController.tsx b/packages/ra-core/src/controller/ListController.tsx
@@ -113,7 +113,7 @@ const defaultSort = {
 const ListController = (props: Props) => {
     useCheckMinimumRequiredProps(
         'List',
-        ['basePath', 'location', 'resource'],
+        ['basePath', 'location', 'resource', 'children'],
         props
     );
     if (props.filter && isValidElement(props.filter)) {

diff --git a/packages/ra-core/src/controller/ShowController.tsx b/packages/ra-core/src/controller/ShowController.tsx
@@ -71,7 +71,7 @@ interface Props {
  *     export default App;
  */
 const ShowController = (props: Props) => {
-    useCheckMinimumRequiredProps('Show', ['basePath', 'resource'], props);
+    useCheckMinimumRequiredProps('Show', ['basePath', 'resource', 'children'], props);
     const { basePath, children, id, resource } = props;
     const translate = useTranslate();
     const version = useVersion();
@@ -96,9 +96,7 @@ const ShowController = (props: Props) => {
         id,
         record,
     });
-    if (!children) {
-        return null;
-    }
+
     return children({
         isLoading: loading,
         defaultTitle,