Merge pull request #2595 from marmelab/disable-export-no-data

[RFR] Disable the Export button when there is nothing to export
marmelab · Dec 5, 2018 · 1618935 · 1618935
2 parents e6e7611 + 3419db6
commit 1618935
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/docs/List.md b/docs/List.md
@@ -100,7 +100,8 @@ const PostActions = ({
     onUnselectItems,
     resource,
     selectedIds,
-    showFilter
+    showFilter,
+    total
 }) => (
     <CardActions>
         {bulkActions && React.cloneElement(bulkActions, {
@@ -119,6 +120,7 @@ const PostActions = ({
         }) }
         <CreateButton basePath={basePath} />
         <ExportButton
+            disabled={total === 0}
             resource={resource}
             sort={currentSort}
             filter={filterValues}
@@ -149,7 +151,9 @@ export const PostList = ({ permissions, ...props }) => (
 
 ### Exporter
 
-Among the default list actions, react-admin includes an `<ExportButton>`. By default, clicking this button will:
+Among the default list actions, react-admin includes an `<ExportButton>`. This button is disabled when there is no record in the current `<List>`.
+
+By default, clicking this button will:
 
 1. Call the `dataProvider` with the current sort and filter (but without pagination),
 2. Transform the result into a CSV string,

diff --git a/packages/ra-ui-materialui/src/list/ListActions.js b/packages/ra-ui-materialui/src/list/ListActions.js
@@ -20,6 +20,7 @@ const Actions = ({
     selectedIds,
     onUnselectItems,
     showFilter,
+    total,
     ...rest
 }) => (
     <CardActions className={className} {...sanitizeListRestProps(rest)}>
@@ -41,6 +42,7 @@ const Actions = ({
             })}
         {hasCreate && <CreateButton basePath={basePath} />}
         <ExportButton
+            disabled={total === 0}
             resource={resource}
             sort={currentSort}
             filter={filterValues}
@@ -63,6 +65,7 @@ Actions.propTypes = {
     onUnselectItems: PropTypes.func.isRequired,
     selectedIds: PropTypes.arrayOf(PropTypes.any),
     showFilter: PropTypes.func,
+    total: PropTypes.number.isRequired,
 };
 
 Actions.defaultProps = {