Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when FloatingActionButton.setOnSpeedDialMenuCloseListener() get's null as parameter #26

Closed
tihomirleka opened this issue Mar 13, 2018 · 3 comments
Closed

Crash when FloatingActionButton.setOnSpeedDialMenuCloseListener() get's null as parameter #26

tihomirleka opened this issue Mar 13, 2018 · 3 comments
Labels
bug

Comments

@tihomirleka
Copy link

Hi,

I just updated from Java to Kotlin (latest) version of the library and my app crashes when I try to pass null to FloatingActionButton.setOnSpeedDialMenuCloseListener() method.

I get the following error

Fatal Exception: java.lang.IllegalArgumentException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkParameterIsNotNull, parameter listener
       at uk.co.markormesher.android_fab.FloatingActionButton.setOnSpeedDialMenuCloseListener(FloatingActionButton.kt)

I don't know Kotlin so I'm not sure what's the problem.
@markormesher
Copy link
Owner

Hey @tihomirleka - thanks for flagging this! I can see the problem; I'll release a fix shortly.

markormesher pushed a commit that referenced this issue Mar 13, 2018
Allow nullable speed-dial open/close listeners (fixes #26)
71b43a4
@markormesher
Copy link
Owner

Fixed in v2.2.1 - let me know if you have any other issues! 👍

@tihomirleka
Copy link
Author

Just tested it. No crash. Thanks

@markormesher markormesher mentioned this issue Mar 15, 2018
Closed
markormesher added a commit that referenced this issue Mar 15, 2018
@markormesher
Refactor speedDialMenuOpen flag to include 'is'; make flag readable (#26
b0dc220 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tihomirleka @markormesher