-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setOnSpeedMenuDialOpenListener() has wrong name #23
Comments
@markormesher Swapping the method name is obviously a breaking change, so I don't know how you want to handle this. |
Ha, wow, good spot. I think an alias is the best approach to fixing this, so we can move forwards with the right naming convention without breaking anything. I'll tag this issue in a commit shortly. |
@barbeau I'll be merging this and cutting a new release tonight. https://github.com/markormesher/android-fab/compare/fix-speed-dial-listener-naming-mistake |
Awesome, thanks! |
With v2.0, code to set the open and close listener looks like this:
The naming convention of the two set listeners methods are different:
setOnSpeedMenuDialOpenListener()
setOnSpeedDialMenuCloseListener()
Judging by the
setSpeedDialMenuAdapter()
method, it looks like the open listener method:setOnSpeedMenuDialOpenListener()
should have been:
setOnSpeedDialMenulOpenListener()
The text was updated successfully, but these errors were encountered: