Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure keyword operators are always followed by a space #146

Merged

Conversation

DylanPiercey
Copy link
Contributor

Fixes an issue where attribute names that started with a keyword (eg: as-thing or instanceof-thing) were incorrectly treated as an expression continuation.

@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2023

🦋 Changeset detected

Latest commit: 85b10c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
htmljs-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 92.13% // Head: 93.23% // Increases project coverage by +1.09% 🎉

Coverage data is based on head (85b10c4) compared to base (b232aa2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   92.13%   93.23%   +1.09%     
==========================================
  Files          26       26              
  Lines        1259     1271      +12     
  Branches      267      287      +20     
==========================================
+ Hits         1160     1185      +25     
+ Misses         62       55       -7     
+ Partials       37       31       -6     
Impacted Files Coverage Δ
src/states/EXPRESSION.ts 93.37% <ø> (-0.05%) ⬇️
src/states/JS_COMMENT_LINE.ts 77.77% <0.00%> (-9.73%) ⬇️
src/states/CONCISE_HTML_CONTENT.ts 89.23% <0.00%> (-2.84%) ⬇️
src/states/HTML_CONTENT.ts 91.89% <0.00%> (-2.48%) ⬇️
src/states/TAG_NAME.ts 98.24% <0.00%> (+0.03%) ⬆️
src/states/ATTRIBUTE.ts 95.20% <0.00%> (+2.14%) ⬆️
src/states/PLACEHOLDER.ts 97.61% <0.00%> (+2.38%) ⬆️
src/states/OPEN_TAG.ts 90.43% <0.00%> (+2.56%) ⬆️
src/core/Parser.ts 92.75% <0.00%> (+4.43%) ⬆️
src/states/CLOSE_TAG.ts 93.33% <0.00%> (+4.44%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DylanPiercey DylanPiercey merged commit bcfd809 into main Jan 24, 2023
@DylanPiercey DylanPiercey deleted the fix-issue-parsing-attr-names-starting-with-keyword branch January 24, 2023 20:55
@github-actions github-actions bot mentioned this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant