Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize parser constructor #136

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

DylanPiercey
Copy link
Contributor

Description

Small parser performance improvement by optimizing the base parser constructor to not initialize undefined properties.

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2022

🦋 Changeset detected

Latest commit: 0ba0cde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
htmljs-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #136 (0ba0cde) into main (cdbc6b2) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   92.14%   92.13%   -0.01%     
==========================================
  Files          26       26              
  Lines         802      801       -1     
  Branches      268      268              
==========================================
- Hits          739      738       -1     
  Misses         48       48              
  Partials       15       15              
Impacted Files Coverage Δ
src/core/Parser.ts 90.10% <100.00%> (-0.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@DylanPiercey DylanPiercey merged commit b5fa4d0 into main Aug 17, 2022
@DylanPiercey DylanPiercey deleted the parser-constructor-perf-improvement branch August 17, 2022 15:45
@github-actions github-actions bot mentioned this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant