Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression with comments inside parsed text state #132

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

DylanPiercey
Copy link
Contributor

Description

Fixes an issue where parsed text state tags (eg <script>) were not properly being ended if the line ended with a comment.
This was a regression.

<script>// This should close even though there is a line comment on the same line</script>

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2022

🦋 Changeset detected

Latest commit: 0050198

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
htmljs-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #132 (0050198) into main (ab0abcf) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   92.02%   92.01%   -0.01%     
==========================================
  Files          26       26              
  Lines         803      802       -1     
  Branches      268      267       -1     
==========================================
- Hits          739      738       -1     
  Misses         49       49              
  Partials       15       15              
Impacted Files Coverage Δ
src/states/JS_COMMENT_LINE.ts 71.42% <ø> (ø)
src/states/PARSED_TEXT_CONTENT.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@DylanPiercey DylanPiercey merged commit 59a10d5 into main Aug 9, 2022
@DylanPiercey DylanPiercey deleted the fix-script-comment-regression branch August 9, 2022 04:10
@github-actions github-actions bot mentioned this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant